VisionFive2 Linux kernel

author: Al Viro <viro@zeniv.linux.org.uk> 2012-10-16 13:30:07 -0400 committer: Al Viro <viro@zeniv.linux.org.uk> 2012-10-16 13:36:50 -0400 commit: 45525b26a46cd593cb72070304c4cd7c8391bd37 parent: dd8e8c4a2c902d8350b702e7bc7c2799e5e7e331

Commit Summary:

fix a leak in replace_fd() users

Diffstat:

1 file changed, 3 insertions, 2 deletions

diff --git a/fs/coredump.c b/fs/coredump.c
index fd37facac8dc..ce47379bfa61 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -450,11 +450,12 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new)
 
 	cp->file = files[1];
 
-	replace_fd(0, files[0], 0);
+	err = replace_fd(0, files[0], 0);
+	fput(files[0]);
 	/* and disallow core files too */
 	current->signal->rlim[RLIMIT_CORE] = (struct rlimit){1, 1};
 
-	return 0;
+	return err;
 }
 
 void do_coredump(siginfo_t *siginfo, struct pt_regs *regs)